Skip to content

[MIG] mail_composer_cc_bcc: Migration to 18.0#232

Open
nouh-bou wants to merge 1 commit into
OCA:18.0from
nouh-bou:18.0-mig-mail_composer_cc_bcc
Open

[MIG] mail_composer_cc_bcc: Migration to 18.0#232
nouh-bou wants to merge 1 commit into
OCA:18.0from
nouh-bou:18.0-mig-mail_composer_cc_bcc

Conversation

@nouh-bou

@nouh-bou nouh-bou commented Jul 9, 2026

Copy link
Copy Markdown

No description provided.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @trisdoan,
some modules you are maintaining are being modified, check this out!

expecting = self.partner_cc2 + self.partner_bcc
self.assertEqual(composer.partner_bcc_ids, expecting)

def test_template_cc_bcc_with_placeholders(self):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this test just removed? It's not applicable anymore?

"name": "Email CC and BCC",
"summary": "This module enables sending mail to CC and BCC partners in mail composer form.", # noqa: E501
"version": "18.0.1.0.2",
"version": "18.0.1.0.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

@ChristophAbenthungCibex

Copy link
Copy Markdown
Contributor

This module is already migrated to version 18.0 -> #3
Why do we need another migration?
Wouldn't it be better to implement the changes into the current version to improve it?

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this PR? The module is already migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:mail_composer_cc_bcc Module mail_composer_cc_bcc series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants