Skip to content

[19.0][ADD] hr_expense_sheet: New module - #378

Open
victoralmau wants to merge 1 commit into
OCA:19.0from
Tecnativa:19.0-add-hr_expense_sheet
Open

[19.0][ADD] hr_expense_sheet: New module#378
victoralmau wants to merge 1 commit into
OCA:19.0from
Tecnativa:19.0-add-hr_expense_sheet

Conversation

@victoralmau

@victoralmau victoralmau commented Aug 13, 2026

Copy link
Copy Markdown
Member

New Module

Related to odoo/odoo#189701

Please @carlos-lopez-tecnativa and @pedrobaeza can you review it?

@Tecnativa TT58631

@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch 3 times, most recently from bddc833 to af8424a Compare August 13, 2026 12:55
@Saran440

Copy link
Copy Markdown
Member

@victoralmau Thanks for your work.
When I add a line to the expense report, the Upload and New buttons should not appear at the top.
Screenshot 2026-08-18 085709

@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from af8424a to 0b512c3 Compare August 18, 2026 14:31
victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 19, 2026
victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 19, 2026
@pedrobaeza pedrobaeza added this to the 19.0 milestone Aug 19, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

Trying to load demo data, I found this problem:

imagen

It's also curious that the runboat didn't contain any installed module. That happens AFAIK when some module can't be loaded.

@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from 0b512c3 to 8301175 Compare August 19, 2026 07:28
victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 19, 2026
@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from 8301175 to 9f794c2 Compare August 19, 2026 07:32
@victoralmau

Copy link
Copy Markdown
Member Author

Trying to load demo data, I found this problem:

Fixed

victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 19, 2026
victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 21, 2026
@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from 9f794c2 to 167c258 Compare August 21, 2026 14:40
victoralmau added a commit to Tecnativa/OpenUpgrade that referenced this pull request Aug 21, 2026
@haivanlive

Copy link
Copy Markdown

I cannot find the 'New' button in the list view to create a new record hr.expense.sheet. Please check and fix this issue when you have a moment.

image

@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from 167c258 to a224344 Compare August 26, 2026 10:57
@victoralmau

Copy link
Copy Markdown
Member Author

I cannot find the 'New' button in the list view to create a new record hr.expense.sheet. Please check and fix this issue when you have a moment.

Fixed!

@victoralmau
victoralmau marked this pull request as ready for review August 26, 2026 11:01
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml
Comment thread hr_expense_sheet/views/hr_expense_views.xml
Comment thread hr_expense_sheet/models/hr_expense.py
Comment thread hr_expense_sheet/views/hr_expense_views.xml
Comment thread hr_expense_sheet/views/hr_expense_views.xml
@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch from a224344 to 8063058 Compare August 27, 2026 07:21
@victoralmau victoralmau changed the title [19.0][ADD] hr_expense_sheet: New Module [19.0][ADD] hr_expense_sheet: New module Aug 27, 2026
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml Outdated
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml Outdated
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml Outdated
Comment thread hr_expense_sheet/models/account_move.py
@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch 2 times, most recently from d38ee7d to fb1e339 Compare August 28, 2026 12:32
Comment thread hr_expense_sheet/views/hr_expense_views.xml
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml
Comment thread hr_expense_sheet/views/hr_expense_sheet_views.xml Outdated
Comment thread hr_expense_sheet/security/ir_rule.xml Outdated
Comment thread hr_expense_sheet/static/src/views/expense_line_widget.esm.js Outdated
Comment thread hr_expense_sheet/__manifest__.py
@victoralmau
victoralmau force-pushed the 19.0-add-hr_expense_sheet branch 2 times, most recently from 509e564 to ca388cf Compare September 1, 2026 13:03

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment to understand the reason.

Comment thread hr_expense_sheet/hooks.py Outdated
Comment thread hr_expense_sheet/hooks.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants