[FIX] agreement_legal: copy agreement not get the current agreement I…

[lbarry-apsl]

When an agreement is copied from the template, the temp_agreement_id does not pick up the ID of the new agreement, which makes it impossible to select the section of the created agreement.

cc https://github.com/APSL

@shirashi3771 @palomagrc93 @miquelalzanillas @peluko00 @BernatObrador @cubells @miquelpascual @ppyczko @isugac @javierobcn please review.

[OCA-git-bot]

Hi @max3903, @ygol,
some modules you are maintaining are being modified, check this out!

[cubells]

Suggested change

	values = {"agreement_id": res.id}
	values = {
	"agreement_id": res.id,
	"temp_agreement_id": res.id,
	}

[lbarry-apsl]

Done @cubells , thanks

[cubells]

👍

LGTM

Code review and test

[miquelpascual]

LGTM!

[lbarry-apsl]

Hi @max3903 , can be merge?

[max3903]

Thanks for the fix — the copy() change looks correct for the reported issue (temp_agreement_id must point at the new agreement so the section domain works).

One related gap: recompute_from_template still copies clauses with only agreement_id set:

https://github.com/OCA/agreement/blob/18.0/agreement_legal/models/agreement.py#L297-L301

That path has the same symptom after “reset from template”. Could you apply the same temp_agreement_id assignment there (and ideally a short regression test that copied/recomputed clauses have temp_agreement_id == agreement_id)?

Otherwise LGTM for merging the copy fix as-is and doing that as a tiny follow-up.

[lbarry-apsl]

Thanks for the fix — the copy() change looks correct for the reported issue (temp_agreement_id must point at the new agreement so the section domain works).

One related gap: recompute_from_template still copies clauses with only agreement_id set:

https://github.com/OCA/agreement/blob/18.0/agreement_legal/models/agreement.py#L297-L301

That path has the same symptom after “reset from template”. Could you apply the same temp_agreement_id assignment there (and ideally a short regression test that copied/recomputed clauses have temp_agreement_id == agreement_id)?

Otherwise LGTM for merging the copy fix as-is and doing that as a tiny follow-up.

Sure @max3903 , no problem, I'll add the other correction and the test

[lbarry-apsl]

Hi @max3903 , I've already made the changes, can you check?

[max3903]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-133-by-max3903-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at d337a0b. Thanks a lot for contributing to OCA. ❤️