[19.0][MIG] agreement_legal: Migration to 19.0 by max3903 · Pull Request #132 · OCA/agreement

max3903 · 2026-08-28T23:21:40Z

Summary

Clean migration of agreement_legal from 18.0 to 19.0 (no module split/refactor).

Version 19.0.1.0.0, installable
Reuse agreement.group_* (drop duplicate res_groups.xml / ACL overlaps)
19.0 API/UI updates (self.env._(), settings target current, remove @odoo-module)
Credits: Open Source Integrators → Groundwire Mentored Learning
Unit tests on BaseCommon; coverage 100%

This is an alternative to #121 (migration + refactoring). Prefer this PR for a straight migration.

Test scenario

Install agreement then agreement_legal on Odoo 19.0 (demo optional).
Open the Legal Agreements app menu; confirm dashboard and agreement list/kanban/form load.
Create an agreement from a template; recompute from template via the wizard.
Confirm stages, parties, and readonly-by-stage behavior on the form.
Uninstall agreement_legal and confirm the base Agreements menu is usable again.
Automated: oca_run_tests with ADDONS=agreement_legal — 0 failures; Python coverage on module 100%.

Dependencies

agreement — already on 19.0

Made with Cursor

max3903 · 2026-08-28T23:21:53Z

/ocabot migration agreement_legal

OCA-git-bot · 2026-08-28T23:22:02Z

The migration issue (#90) has not been updated to reference the current pull request because a previous pull request (#121) is not closed.
Perhaps you should check that there is no duplicate work.
CC @CRogos

CRogos

Commit history not preserved
Maybe you should use my migration, before the module split? 00e711d

[UPD] Update agreement_legal.pot

- Add stage_type to agreement.stage - Track stage of service profile - Add Kanban view for service profiles to the dashboard - Add product_id field to service profile [UPD] Update agreement_legal.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/ Added translation using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Simplified)) Currently translated at 4.5% (13 of 287 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/zh_CN/ Translated using Weblate (Chinese (Simplified)) Currently translated at 39.4% (113 of 287 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/zh_CN/ Translated using Weblate (Chinese (Simplified)) Currently translated at 53.0% (152 of 287 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/zh_CN/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (287 of 287 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/zh_CN/

Co-Authored-By: kongrattapong <52144935+kongrattapong@users.noreply.github.com> Translated using Weblate (French) Currently translated at 100.0% (287 of 287 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/

we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default) [UPD] Update agreement_legal.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/ Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (284 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/zh_CN/

Translated using Weblate (Portuguese (Portugal)) Currently translated at 73.9% (210 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_PT/ Added translation using Weblate (Portuguese) Translated using Weblate (Portuguese) Currently translated at 75.4% (214 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt/ Translated using Weblate (Portuguese) Currently translated at 75.7% (215 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt/ Translated using Weblate (Portuguese) Currently translated at 75.7% (215 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt/

Before this commit, the view of agreement uses a dotted domain on the 'right leaf' in the company_conact_id field causing an javascript error. Translated using Weblate (Portuguese (Portugal)) Currently translated at 73.9% (210 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_PT/ Translated using Weblate (Portuguese) Currently translated at 77.5% (220 of 284 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt/ [UPD] Update agreement_legal.pot

[UPD] Update agreement_legal.pot

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477 [UPD] Update agreement_legal.pot

Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (286 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/ Translated using Weblate (Spanish) Currently translated at 99.3% (284 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/es/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (286 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (286 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/ Translated using Weblate (French) Currently translated at 98.6% (282 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (286 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/pt_BR/ Translated using Weblate (French) Currently translated at 100.0% (286 of 286 strings) Translation: contract-12.0/contract-12.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_legal/fr/

[MIG] Black & Cleanup [IMP] Reviewer Requested Changes [IMP] Black [IMP] Reviewer Suggestion [FIX] Tests [FIX] Multiple Issues - Added 'is_old_version' field to better display old versions. Before these were marked as inactive therefore not showing in the agreement. - 'is_template' field now copies when making a template revision or copying a template. - New Versions now retain original create date. - Moved version/revision and created on/by fields out of footer to top in order to have the save buttons when creating children. - Moved demo data out of data folder into the demo.xml [FIX] demo data [FIX] Revert back to only migration [FIX] Report dynamic field rendering [FIX] Test

…ents TT32359

…document

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Currently translated at 100.0% (263 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Currently translated at 100.0% (263 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/it/

Currently translated at 98.4% (259 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/tr/

Fixes OCA#107 - Move kanban card actions to Odoo 18 `menu` template with highlight_color - Use dedicated agreement_legal_menu_root so sibling modules do not hijack agreement.agreement_menu under Accounting - Split demo data per model

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Fixes OCA#106 Use a dedicated legal app root menu instead of reusing agreement.agreement_menu, hide the base app menu while legal is installed, and restore it via uninstall_hook.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Assisted-by: Cursor <cursoragent@cursor.com>

max3903 added needs review migration series:19.0 labels Aug 28, 2026

OCA-git-bot added the mod:agreement_legal Module agreement_legal label Aug 28, 2026

max3903 added this to the 19.0 milestone Aug 28, 2026

max3903 self-assigned this Aug 28, 2026

CRogos mentioned this pull request Sep 3, 2026

[19.0][MIG] agreement_legal: Migration to 19.0 + Refactoring #121

Closed

CRogos reviewed Sep 3, 2026

View reviewed changes

ygol and others added 20 commits September 3, 2026 07:16

[ADD] agreement_legal migration

fca5e0f

[FIX][12.0] Menu Icon.

a5ce165

[UPD] Update agreement_legal.pot

[FIX] Icon in settings

4ab56ee

[UPD] update agreement demo data with compulsory fields

d5159a5

[FIX] company_partner_id and partner_id have the same label: Partner.

c20c619

[UPD] Update agreement_legal.pot

[IMP] agreement,agreement_legal: support activities

c83acbf

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477 [UPD] Update agreement_legal.pot

[12.0][FIX] agreement_legal: Error when mass action on list view

00f84c3

[14.0][ENH] agreement_legal

9f3aa76

[FIX] agreement_legal: Change create_new_version() function in agreem…

931fcf3

…ents TT32359

[IMP] agreement_legal: Add agreement list button

bc41059

Added translation using Weblate (Spanish (Argentina))

2a38688

[MIG] agreement_legal: Migration to 15.0

14a05a8

[IMP] agreement_legal: black, isort, prettier

d017d7b

MohamedOsman7 and others added 14 commits September 3, 2026 07:16

[IMP] agreement_legal: refactor agreement form to inherit base view

4184331

[REF] agreement_legal: Replace repeated dynamic field code with mixin

6bba9f2

[FIX] agreement_legal: remove redundant t-name from report_agreement_…

765e097

…document

Added translation using Weblate (Turkish)

12b1cab

[BOT] post-merge updates

2fbc852

[UPD] Update agreement_legal.pot

8c5ec6a

[BOT] post-merge updates

4618c68

Update translation files

512a053

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Translated using Weblate (Italian)

e8c9c40

Currently translated at 100.0% (263 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/it/

[UPD] Update agreement_legal.pot

b194e14

[BOT] post-merge updates

a00ce1b

Update translation files

8d14bc7

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

Translated using Weblate (Italian)

8a814c8

Currently translated at 100.0% (263 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/it/

Translated using Weblate (Turkish)

48ee015

Currently translated at 98.4% (259 of 263 strings) Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/tr/

max3903 force-pushed the 19.0-mig-agreement_legal branch from f865b00 to 8875afe Compare September 3, 2026 13:19

max3903 and others added 14 commits September 3, 2026 07:53

[UPD] Update agreement_legal.pot

cf9cf50

[BOT] post-merge updates

dbc7aea

Update translation files

bf03d96

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

[FIX] agreement_legal: preserve base Agreements menu on uninstall

b82f2c3

Fixes OCA#106 Use a dedicated legal app root menu instead of reusing agreement.agreement_menu, hide the base app menu while legal is installed, and restore it via uninstall_hook.

[BOT] post-merge updates

9e7df9f

[IMP] agreement_legal: Add field translations

21529cb

fix(agreement_legal) Fix OCA#62

4f26897

[IMP] agreement_legal: Recompute from template

0895f39

[FIX] Fix duplicated clauses

340e547

[UPD] Update agreement_legal.pot

2d12f4c

[BOT] post-merge updates

6459931

Update translation files

3f8bd59

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement_legal Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_legal/

[MIG] agreement_legal: Migration to 19.0

dbfaf2d

Assisted-by: Cursor <cursoragent@cursor.com>

max3903 force-pushed the 19.0-mig-agreement_legal branch from 8875afe to dbfaf2d Compare September 3, 2026 13:54

Navigation Menu

Uh oh!

Uh oh!

[19.0][MIG] agreement_legal: Migration to 19.0 - #132

[19.0][MIG] agreement_legal: Migration to 19.0#132
max3903 wants to merge 86 commits into
OCA:19.0from
ursais:19.0-mig-agreement_legal

max3903 commented Aug 28, 2026

Uh oh!

max3903 commented Aug 28, 2026

Uh oh!

OCA-git-bot commented Aug 28, 2026

Uh oh!

CRogos left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

max3903 commented Aug 28, 2026

Summary

Test scenario

Dependencies

Uh oh!

max3903 commented Aug 28, 2026

Uh oh!

OCA-git-bot commented Aug 28, 2026

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants