[19.0][FIX] sale_management: create sections for optional products - #5975
Merged
Conversation
hbrunn
force-pushed
the
19.0-sale_management-sections
branch
from
September 8, 2026 09:39
025f940 to
9a0e854
Compare
pedrobaeza
reviewed
Sep 8, 2026
| AND res_users.partner_id=res_partner.id | ||
| AND display_type='line_section' | ||
| AND is_optional=True | ||
| AND res_partner.lang=%s |
Member
There was a problem hiding this comment.
Suggested change
| AND res_partner.lang=%s | |
| AND COALESCE(res_partner.lang, 'en_US')=%s |
[FIX] sale_management: copy translated strings correctly fixes OCA#5970
hbrunn
force-pushed
the
19.0-sale_management-sections
branch
from
September 8, 2026 15:39
9a0e854 to
b1762ba
Compare
pedrobaeza
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5970
the information about a line being optional or not lives on the section coming before that line (not the is_optional field of the line itself), so we need to reorder lines and inject a new optional section for every order that has optional products.
while being on it, this fixes copying the json dict of translated sale.order.template.option#name to sale.order.template.line#name