Skip to content

[15.0][OU-FIX] base: fix mail.default.from conflict during migration #5948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celm1990 wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][OU-FIX] base: fix mail.default.from conflict during migration #5948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion openupgrade_scripts/scripts/base/15.0.1.3/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@
]


def _fix_icp_mail_default_from(cr):
"""Odoo 15 added a new ir.config_parameter key for mail.default.from.
See https://github.com/odoo/odoo/commit/1b9dd118cb0f305ed38b6326fa814336cbf16252
If a manual record was created in the database, it causes the following error:
DETAIL: Key (key)=(mail.default.from) already exists.
Therefore, the XML ID was added to prevent this error.
"""
cr.execute("SELECT id FROM ir_config_parameter WHERE key = 'mail.default.from'")
res_id = cr.fetchone()
if res_id:
openupgrade.add_xmlid(
cr, "base", "icp_mail_default_from", "ir.config_parameter", res_id[0], True
)


@openupgrade.migrate(use_env=False)
def migrate(cr, version):
"""
Expand All @@ -69,7 +84,7 @@ def migrate(cr, version):

openupgrade.rename_xmlids(cr, rename_xmlids_l10n_ec)
openupgrade.rename_xmlids(cr, rename_xmlids_mail)

_fix_icp_mail_default_from(cr)
openupgrade.update_module_names(
cr, renamed_modules.items(), environment_namespec=True
)
Expand Down
Loading