Skip to content

[19.0][OU-ADD] hr_skills_slides: Migration script - #5849

Merged
OCA-git-bot merged 2 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_skills_slides
Aug 4, 2026
Merged

[19.0][OU-ADD] hr_skills_slides: Migration script#5849
OCA-git-bot merged 2 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_skills_slides

Conversation

@BhaveshHeliconia

@BhaveshHeliconia BhaveshHeliconia commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels Jul 28, 2026
@BhaveshHeliconia

BhaveshHeliconia commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Depends on :

@hbrunn

hbrunn commented Jul 28, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@BhaveshHeliconia no need to do that, when users with write permissions write here

/ocabot migration hr_skills_slides

this is filled in automatically

Depends on :

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jul 28, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 28, 2026
Open
hbrunn
hbrunn requested changes Jul 28, 2026
View reviewed changes
Comment thread openupgrade_scripts/scripts/hr_skills_slides/19.0.1.0/pre-migration.py Outdated
Comment thread openupgrade_scripts/scripts/hr_skills_slides/19.0.1.0/pre-migration.py Outdated
Comment thread openupgrade_scripts/scripts/hr_skills_slides/19.0.1.0/pre-migration.py Outdated
Comment thread openupgrade_scripts/scripts/hr_skills_slides/19.0.1.0/upgrade_analysis_work.txt
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 19.0-mig-hr_skills_slides branch from 4aef173 to 13e506a Compare July 29, 2026 04:34
@BhaveshHeliconia

BhaveshHeliconia commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@hbrunn Thank you for taking the time to review this! I really appreciate your guidance.

I have pushed a fix addressing all your comments. I will be more careful next time and make sure to avoid these kinds of mistakes.

Thanks again for pointing these out!

hbrunn
hbrunn requested changes Aug 4, 2026
View reviewed changes
Comment thread openupgrade_scripts/scripts/hr_skills_slides/19.0.1.0/upgrade_analysis_work.txt
hbrunn
hbrunn approved these changes Aug 4, 2026
View reviewed changes

@hbrunn hbrunn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@hbrunn

hbrunn commented Aug 4, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-5849-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
OCA-git-bot merged commit 1666191 into OCA:19.0 Aug 4, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1666191. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbrunn hbrunn hbrunn approved these changes
@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees

No one assigned

Labels

approved Dependency OK merged 🎉 mod:openupgrade_scripts Module openupgrade_scripts ready to merge series:19.0

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@BhaveshHeliconia @hbrunn @OCA-git-bot @MiquelRForgeFlow