fix(generator): cast frame.LEN in min() so WS read compiles under MSVC#37
Open
binaryduke wants to merge 1 commit into
Open
fix(generator): cast frame.LEN in min() so WS read compiles under MSVC#37binaryduke wants to merge 1 commit into
binaryduke wants to merge 1 commit into
Conversation
generator.h WebSocket frame read calls min( sx, frame.LEN ), mixing ulong (sx) and uchar_64 (frame.LEN). With the namespaced min<T> from NodeppOfficial#32, template argument deduction fails on this mismatch under MSVC 2022 (/std:c++20), so the WebSocket translation unit does not build on Windows. One-line cast resolves it, matching the existing cast style at other min() call sites in this file. Verified: dev builds clean on MSVC 2022 x64 /std:c++20 /MT and the NodeppOfficial#36 WebSocket connect path runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generator.h (WebSocket frame read) calls
min( sx, frame.LEN ), mixingulong(sx) and
uchar_64(frame.LEN). With the namespacedmin<T>from #32, templateargument deduction fails on this mismatch under MSVC 2022 (/std:c++20), so the
WebSocket translation unit does not build on Windows.
One-line cast resolves it, matching the existing style elsewhere in this file
(e.g. the other min() call sites already cast their arguments):
Verified: with this cast, dev builds clean on MSVC 2022 x64 /std:c++20 /MT and
the #36 WebSocket connect path runs (see the #36 confirmation).