Skip to content

ffmpeg-headless: fix riscv64-linux build - #525606

Draft
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:ffmpeg_riscv
Draft

ffmpeg-headless: fix riscv64-linux build#525606
liberodark wants to merge 1 commit into
NixOS:masterfrom
liberodark:ffmpeg_riscv

Conversation

@liberodark

@liberodark liberodark commented May 29, 2026

Copy link
Copy Markdown
Contributor

Fix this issue :

       > TEST    ffmpeg-streamcopy-t
       > TEST    ffmpeg-loopback-decoding
       > TEST    acodec-pcm-alaw
       > TEST    acodec-pcm-mulaw
       > TEST    acodec-pcm-s16be
       > TEST    acodec-pcm-s16le
       > TEST    acodec-pcm-u16be
       > TEST    acodec-pcm-u16le
       > TEST    acodec-pcm-s8
       > --- ./tests/ref/fate/ffmpeg-filter-in-eof       1970-01-01 00:00:01.000000000 +0000
       > +++ tests/data/fate/ffmpeg-filter-in-eof    2026-05-29 14:03:33.034874712 +0000
       > @@ -47,7 +47,7 @@
       >  0,         41,         41,        1,   152064, 0x8e364e18
       >  0,         42,         42,        1,   152064, 0xb15d38c8
       >  0,         43,         43,        1,   152064, 0xf25f6acc
       > -0,         44,         44,        1,   152064, 0xf34ddbff
       > +0,         44,         44,        1,   152064, 0x9b995435
       >  0,         45,         45,        1,   152064, 0xfc7bf570
       >  0,         46,         46,        1,   152064, 0x9dc72412
       >  0,         47,         47,        1,   152064, 0x445d1d59
       > TEST    acodec-pcm-u8
       > Test ffmpeg-filter-in-eof failed. Look at tests/data/fate/ffmpeg-filter-in-eof.err for details.
       > make: *** [tests/Makefile:322: fate-ffmpeg-filter-in-eof] Error 1
       > make: *** Waiting for unfinished jobs....
       > TEST    acodec-pcm-s24be

Things done

@liberodark
liberodark marked this pull request as ready for review May 29, 2026 14:46
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels May 29, 2026
@liberodark

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 525606
Commit: c4e17684e36a9cfb2e1e9f6c92160d91561552e6 (subsequent changes)
Merge: 78bb8e718ab0d91dd247b605996062e64836a05e

Logs: https://github.com/liberodark/nixpkgs-review-gha/actions/runs/26645126435


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@liberodark liberodark added the backport release-26.05 Backport PR automatically label May 29, 2026
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label May 29, 2026
@liberodark
liberodark requested review from Atemu and dotlambda May 29, 2026 16:04
&& stdenv.hostPlatform.isRiscV64
)
[
./fix-fate-ffmpeg-filter-in-eof-8.1.patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment with the URL to an upstream PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Sorry have not upstream this fix have only do that for fix build issue.

Best Regards

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening an upstream PR? We don't want to carry the patch forever

@liberodark
liberodark marked this pull request as draft July 6, 2026 14:52
@liberodark
liberodark force-pushed the ffmpeg_riscv branch 3 times, most recently from 5b3f1c2 to ffa7305 Compare July 12, 2026 20:47
@liberodark liberodark removed the backport release-26.05 Backport PR automatically label Aug 8, 2026
@liberodark
liberodark force-pushed the ffmpeg_riscv branch 2 times, most recently from c18757a to 7c6b5d9 Compare August 18, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants