test(agent-loops): cover claude/gemini provider diagnostics in review scripts - #30
Open
qiaobochi040726-source wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Summary
Adds explicit Claude and Gemini diagnostic-message test coverage to both agent-loops review entrypoints:
specialist-review.sh— 2 new tests: explicit Claude run verifiesClaude budget+Claude model overridediagnostics; explicit Gemini run verifiesGemini model override; each case asserts diagnostics from inactive providers are absent.diff-test-audit.sh— same 2 new tests. This script was missing theClaude model overridestderr diagnostic entirely (it only printedClaude budget), so the fix adds the same 3-line blockspecialist-review.shalready has, enabling the Claude test to assert it.Changes
skills/agent-loops/scripts/diff-test-audit.sh: emitClaude model override: <model>whenCLAUDE_MODELis set (mirrors specialist-review.sh lines 555-559).tests/unit/test_agent_loops_review_scripts.py: +330 lines, 4 new tests (test_specialist_review_reports_claude_provider_diagnostics,test_specialist_review_reports_gemini_provider_diagnostics,test_test_review_reports_claude_provider_diagnostics,test_test_review_reports_gemini_provider_diagnostics).Acceptance criteria
Note: execution behavior was already covered and is untouched; this change is limited to operator-facing stderr diagnostics and their tests.