Skip to content

Standardize NEXT logo assets#16

Merged
next-devin merged 2 commits into
mainfrom
brand-standardize-next-logos
Jul 16, 2026
Merged

Standardize NEXT logo assets#16
next-devin merged 2 commits into
mainfrom
brand-standardize-next-logos

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

Summary

  • replace duplicated raster wordmarks with canonical NEXT SVG assets
  • use next-dark on light surfaces and next-white on dark surfaces at the design-system 26px height
  • preserve the existing canonical multi-resolution docs favicon

Validation

  • npm run build (passes: link audit, link validation, TypeScript, and 268 static pages)
  • canonical asset SHA-256 checks match guides/assets/logos

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs a0e961f Commit Preview URL

Branch Preview URL
Jul 16 2026, 02:39 PM

@next-devin
next-devin marked this pull request as ready for review July 15, 2026 16:06
Comment thread app/page.tsx Outdated
<Link href="/" className="flex items-center gap-3">
<img src="/logo-light.png" alt="Next Commerce" width={105} height={21} className="dark:hidden" />
<img src="/logo-dark.png" alt="Next Commerce" width={105} height={21} className="hidden dark:block" />
<img src="/next-dark.svg" alt="Next Commerce" width={79} height={26} className="dark:hidden" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Aspect-ratio mismatch between SVG viewBox and rendered box.

The new SVG has viewBox="0 0 451 148" (ratio 451/148 ≈ 3.0474), but it's being rendered at width={79} height={26} (ratio 79/26 ≈ 3.0385). That's a ~0.3% horizontal squish, which is below most visual perception thresholds but still a non-uniform scale.

Either size the box to the SVG's true ratio (e.g. width={80} height={26} or width={79} height={26} with a tiny tweak) or, since SVGs scale crisply, consider dropping the hard-coded width/height and letting CSS control the size via the natural ratio.

Suggested change
<img src="/next-dark.svg" alt="Next Commerce" width={79} height={26} className="dark:hidden" />
<img src="/next-dark.svg" alt="Next Commerce" width={80} height={26} className="dark:hidden" />

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Comment thread lib/layout.shared.tsx Outdated
<>
<img src="/logo-light.png" alt={siteConfig.companyName} width={105} height={21} className="dark:hidden" />
<img src="/logo-dark.png" alt={siteConfig.companyName} width={105} height={21} className="hidden dark:block" />
<img src="/next-dark.svg" alt={siteConfig.companyName} width={79} height={26} className="dark:hidden" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Same aspect-ratio mismatch as in app/page.tsx — SVG viewBox is 451x148 (ratio ≈ 3.0474) but rendered box is 79x26 (ratio ≈ 3.0385). Adjust to width={80} height={26} to preserve the canonical proportions, or drop the hard-coded dimensions and let CSS size it from the intrinsic SVG ratio.

Suggested change
<img src="/next-dark.svg" alt={siteConfig.companyName} width={79} height={26} className="dark:hidden" />
<img src="/next-dark.svg" alt={siteConfig.companyName} width={80} height={26} className="dark:hidden" />

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The follow-up commit (a0e961f) switches the SVG logo markup to width={451} height={148} with Tailwind h-auto w-24. Because h-auto lets the browser derive the rendered height from the SVG's intrinsic 451/148 ratio, the prior aspect-ratio mismatch is resolved. Both previously raised SUGGESTIONs are no longer reproducible against the current diff.

Files Reviewed (2 files)
  • app/page.tsx
  • lib/layout.shared.tsx
Previous Review Summary (commit 61a69f3)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 61a69f3)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
app/page.tsx 110 Aspect-ratio mismatch: SVG viewBox 451x148 (~3.047) vs rendered 79x26 (~3.038); ~0.3% horizontal squish
lib/layout.shared.tsx 9 Same aspect-ratio mismatch as in app/page.tsx
Files Reviewed (6 files)
  • app/page.tsx - 1 issue
  • lib/layout.shared.tsx - 1 issue
  • public/next-dark.svg - 0 issues
  • public/next-white.svg - 0 issues
  • public/logo-dark.png (deleted) - 0 issues
  • public/logo-light.png (deleted) - 0 issues

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 43.9K · Output: 1.3K · Cached: 126.7K

@next-devin
next-devin merged commit 89909aa into main Jul 16, 2026
3 checks passed
@next-devin
next-devin deleted the brand-standardize-next-logos branch July 16, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant