security: PARTIAL auto-remediation — manual review required - #1499
Open
Ndevu12 wants to merge 1 commit into
Open
security: PARTIAL auto-remediation — manual review required#1499Ndevu12 wants to merge 1 commit into
Ndevu12 wants to merge 1 commit into
Conversation
- quarantine: tests/bots/security/fixtures/infected/.vscode/tasks.json - quarantine: tests/bots/security/fixtures/infected/public/fonts - strip-settings: tests/bots/security/fixtures/infected/.vscode/settings.json - strip-gitignore: tests/bots/security/fixtures/infected/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚠ PARTIAL remediation for
Ndevu12/stayAwakeBotby StayAwakeBot Security Sentinel — this branch applies what is provably safe but is NOT a clean tree (see below).Changes applied
quarantine—tests/bots/security/fixtures/infected/.vscode/tasks.jsonquarantine—tests/bots/security/fixtures/infected/public/fontsstrip-settings—tests/bots/security/fixtures/infected/.vscode/settings.jsonstrip-gitignore—tests/bots/security/fixtures/infected/.gitignore🚨 Still infected — confirmed indicators NOT auto-fixed (manual action required)
19 confirmed finding(s) could not be safely auto-remediated and remain in this tree. Do NOT merge this as a completed fix — the security gate stays red. Resolve each, then re-run
saw fix --pr:src/stayawake/bots/security/data/signatures.yml:263—exfil-shai-hulud-branding(residual):Confirmed indicator still present after remediation — review and remove/recover manually.src/stayawake/bots/security/taint/destructive.py—destructive-home-wipe(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/fixtures/infected/.claude/settings.json—claude-hook-runs-payload(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/fixtures/infected/package.json—npm-lifecycle-dropper(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/fixtures/infected/postcss.config.mjs:2—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_autorun_monitor.py—destructive-home-wipe(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/test_destructive_intent.py—secure-home-wipe(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/test_evasions.py:45—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_exfil_signatures.py:33—exfil-shai-hulud-branding(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/test_installed_package_audit.py:300—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_loader_tier_split.py:73—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_obfuscation_file.py:663—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_recovery.py:36—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_scan_failclosed.py:86—loader-seed-var(intrinsic-match):No clean version in history, but it is a plain literal — likely intentional (test/research data). If so, allowlist ʼloader-seed-varʼ for ʼtests/bots/security/test_scan_failclosed.pyʼ.tests/bots/security/test_scan_parallel.py:31—loader-seed-var(intrinsic-match):No clean version in history, but it is a plain literal — likely intentional (test/research data). If so, allowlist ʼloader-seed-varʼ for ʼtests/bots/security/test_scan_parallel.pyʼ.tests/bots/security/test_tail_residuals.py:42—loader-fromcharcode-127(born-infected):No clean version in git history and the content is packed/obfuscated — likely born infected. Review and, if confirmed, remove/quarantine it.tests/bots/security/test_verdict.py:117—loader-seed-var(intrinsic-match):No clean version in history, but it is a plain literal — likely intentional (test/research data). If so, allowlist ʼloader-seed-varʼ for ʼtests/bots/security/test_verdict.pyʼ.tests/bots/security/test_walk_delete_scope.py—destructive-home-wipe(residual):Confirmed indicator still present after remediation — review and remove/recover manually.tests/bots/security/test_within_target_parallel.py:21—loader-seed-var(intrinsic-match):No clean version in history, but it is a plain literal — likely intentional (test/research data). If so, allowlist ʼloader-seed-varʼ for ʼtests/bots/security/test_within_target_parallel.pyʼ.⚠ Still needs review (not auto-fixed)
These are suspicious (heuristic) matches — possibly a legitimate inlined asset/minified file, possibly a payload the confirmed signatures didn't name. Review each; allowlist if legitimate, or remove if not.
exfil-shai-hulud-token—config/security.yml:81exfil-shai-hulud-token—docs/explanation/credential-hygiene.md:21loader-clientcode-error—src/stayawake/bots/security/data/signatures.yml:67exfil-shai-hulud-token—src/stayawake/bots/security/data/signatures.yml:258exfil-shai-hulud-token—src/stayawake/bots/security/hygiene/autorun/grade.py:527exfil-shai-hulud-token—src/stayawake/bots/security/hygiene/models.py:42exfil-shai-hulud-token—src/stayawake/bots/security/hygiene/runner.py:11exfil-shai-hulud-token—src/stayawake/bots/security/taint/destructive.py:228claude-hook-autorun—tests/bots/security/fixtures/infected/.claude/settings.jsonnpm-lifecycle-exec—tests/bots/security/fixtures/infected/package.jsonnpm-lifecycle-exec—tests/bots/security/fixtures/infected/package.jsonloader-decoder-fn—tests/bots/security/fixtures/infected/postcss.config.mjs:2whitespace-concealment—tests/bots/security/fixtures/infected/postcss.config.mjs:2exfil-shai-hulud-token—tests/bots/security/test_autorun_monitor.py:138loader-decoder-fn—tests/bots/security/test_evasions.py:30exfil-shai-hulud-token—tests/bots/security/test_exfil_signatures.py:2loader-decoder-fn—tests/bots/security/test_installed_package_audit.py:300loader-decoder-fn—tests/bots/security/test_loader_tier_split.py:79loader-clientcode-error—tests/bots/security/test_loader_tier_split.py:97loader-decoder-fn—tests/bots/security/test_obfuscation_file.py:111exfil-shai-hulud-token—tests/bots/security/test_pr.py:140loader-decoder-fn—tests/bots/security/test_recovery.py:36loader-decoder-fn—tests/bots/security/test_remediation.py:98loader-decoder-fn—tests/bots/security/test_tail_residuals.py:46loader-decoder-fn—tests/bots/security/test_verdict.py:117exfil-shai-hulud-token—tests/bots/security/test_verdict.py:124oversized-config-line—tests/bots/security/fixtures/infected/postcss.config.mjs:2obfuscated-source-file—tests/bots/security/fixtures/infected/postcss.config.mjsOriginals are recoverable from git history. Evil-merge findings (if any) are reported separately and need a manual history rewrite.
Review and merge if correct. This is a single rolling PR — re-runs update it rather than opening duplicates.