Composite Load Model Parameter Export Expansion - #61
Open
HaleyRoss wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The new composite load parameters are added consistently across constants, enums, and default export settings without introducing broken references or invalid mappings.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR expands PyPSSE’s exportable composite load model parameters by adding additional dynamic composite load coefficients (P/Q corner points) to the internal constants, public enumerations, and the default export configuration, enabling these parameters to be included in exports.
Changes:
- Added
P1c,P2c,Q1c,Q2cto the dynamic load model parameter index map (lmodind) and dynamic-only property list. - Extended
LoadPropertiesenum to include the new composite load parameters. - Updated default
export_settings.tomlso load exports include the new parameters by default.
File summaries
| File | Description |
|---|---|
| pypsse/modes/constants.py | Adds P1c/P2c/Q1c/Q2c to dynamic-only load parameter indices and dynamic-only property mapping. |
| pypsse/enumerations.py | Exposes the new load properties via the LoadProperties enum for validation and API usage. |
| pypsse/defaults/export_settings.toml | Updates default load export property list to include the newly supported parameters. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to the list of parameters from the PSS/E composite load model that can be exported.