fix: gamma==1 ignores mul and clip parameters

[andrewwhitecdw]

Problem

fix: gamma==1 ignores mul and clip parameters

Fix

Replace:

    if offset is None:
        if gamma == 1:
            return l1_loss
        # d(x**p)/dx = 1 ==> p * x**(p-1) == 1 ==> x = (1/p)**(1/(p-1))
        offset = (1 / gamma)**(1 / (gamma - 1))

with:

    if offset is None:
        if gamma == 1:
            def loss_func(x, y):
                return mul * l1_loss(x, y).clip(max=clip)
            return loss_func
        # d(x**p)/dx = 1 ==> p * x**(p-1) == 1 ==> x = (1/p)**(1/(p-1))
        offset = (1 / gamma)**(1 / (gamma - 1))

Files changed

• mast3r/cloud_opt/utils/losses.py