fix: avoid double path join when loading NeRF images - #120
Closed
andrewwhitecdw wants to merge 3 commits into
Closed
fix: avoid double path join when loading NeRF images#120andrewwhitecdw wants to merge 3 commits into
andrewwhitecdw wants to merge 3 commits into
Conversation
Auditor: Removing os.path.join(path, ...) makes cam_name relative only to frame['file_path'], so Image.open will fail when the working directory is not the dataset root or when file_path lacks a directory prefix. This does not fix a real double path join (the only join is the one removed) and introduces a loading regression for standard NeRF synthetic layouts.
Auditor: adversarial auditor: empty diff
Author
|
Closing after multiple repair attempts: original patch no longer applies or auditor feedback remains unaddressed. |
andrewwhitecdw
deleted the
bugfix/dataset-readers-avoid-double-path-join-when-loading
branch
August 2, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fix: avoid double path join when loading NeRF images
Fix
Replace:
with:
Files changed
scene/dataset_readers.py