Expose fitted attributes for Dask linear models - #8392
Conversation
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughDask linear models now expose fitted attributes through their underlying solvers. Attribute resolution preserves the configured output type, Ridge fitted attributes remain absent before fitting, and tests cover solver consistency, NumPy output, and refit updates. ChangesDask fitted attributes
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
Signed-off-by: nethum529 <nethumweerasinghe.nw@gmail.com>
| else: | ||
| raise | ||
| finally: | ||
| settings.output_type = previous_output_type |
There was a problem hiding this comment.
Is the output_type setting required for #7460, or is it a separate improvement? It affects all remote Dask estimators, so I think it needs shared coverage here or should be handled separately. If retained, please use with using_output_type(output_type):.
Summary
coef_,intercept_, andn_iter_from Dask ElasticNet and Lasso.coef_andintercept_from its fitted model.Testing
Addresses #7460