Skip to content

Remove pip only skips of numba-cuda-mlir backend tests - #23713

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
brandon-b-miller:remove-ncmlir-conditional-skips
Aug 20, 2026
Merged

Remove pip only skips of numba-cuda-mlir backend tests #23713
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
brandon-b-miller:remove-ncmlir-conditional-skips

Conversation

@brandon-b-miller

Copy link
Copy Markdown
Contributor

Conda packages are now provided for numba-cuda-mlir, cudf doesn't need these skips anymore.

@brandon-b-miller
brandon-b-miller requested a review from a team as a code owner August 18, 2026 21:37
@brandon-b-miller brandon-b-miller added numba Numba issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 18, 2026
@brandon-b-miller

Copy link
Copy Markdown
Contributor Author

cc @mroeschke

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a8e22c7d-0c30-4825-9f64-35bb9e55c9d8

📥 Commits

Reviewing files that changed from the base of the PR and between 215888d and 9e91dbd.

📒 Files selected for processing (3)
  • python/cudf/cudf/tests/private_objects/mlir_backend/test_masked_lowering.py
  • python/cudf/cudf/tests/private_objects/mlir_backend/test_masked_typing.py
  • python/cudf/cudf/tests/private_objects/mlir_backend/test_plumbing.py
💤 Files with no reviewable changes (2)
  • python/cudf/cudf/tests/private_objects/mlir_backend/test_masked_lowering.py
  • python/cudf/cudf/tests/private_objects/mlir_backend/test_masked_typing.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated MLIR backend tests to require the relevant MLIR integration during collection instead of silently skipping when it is unavailable.
    • Removed obsolete test dependency-skip handling.
  • Documentation
    • Updated copyright attribution in the test suite.

Walkthrough

Changes

MLIR test dependency handling

Layer / File(s) Summary
Direct MLIR test imports and metadata
python/cudf/cudf/tests/private_objects/mlir_backend/test_masked_typing.py, python/cudf/cudf/tests/private_objects/mlir_backend/test_plumbing.py
The tests no longer use module-level pytest.importorskip("numba_cuda_mlir") setup. The plumbing test updates its SPDX copyright attribution.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 9e91d

This change enables backend tests that were previously skipped; it is localized to test configuration and no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

  • NVIDIA/cudf#22886: Removes dependency skip logic from tests for masked lowering and typing code.
  • NVIDIA/cudf#23310: Removes dependency-skipping setup from related masked MLIR tests.
  • NVIDIA/cudf#23311: Removes dependency-based skips from the same masked MLIR test modules.

Suggested labels: Python

Suggested reviewers: matt711

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains that Conda packages are available and that the test skips are no longer needed.
Title check ✅ Passed The title clearly identifies the removal of pip-only skips for numba-cuda-mlir backend tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mroeschke mroeschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Didn't realize these were here)

@brandon-b-miller

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b28593a into NVIDIA:main Aug 20, 2026
131 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants