Add float, boolean and array indexing support to Java Variant extraction - #23711
Add float, boolean and array indexing support to Java Variant extraction#23711nartal1 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesVariant extraction support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds float, boolean, and array-path Variant extraction with expanded tests; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test e7645f8 |
Description
This PR contributes to NVIDIA/cudf-spark#15222 and NVIDIA/cudf-spark#15223.
It brings
VariantUtilsin line with Variant functionality subsequently merged into libcudf:FLOAT32andFLOAT64extractionBOOL8extractionIn this PR:
DType.FLOAT32,DType.FLOAT64, andDType.BOOL8to the supported Variant target types$[0]and$.a[1].bVariantUtilsTestcoverage for the newly supported types and path behaviorVariant decoding requires the encoded physical type to exactly match the requested target type. Numeric conversions are not performed. For example, a
FLOAT32Variant value cannot be extracted asFLOAT64; the result is null.Array Indexing
Variant extraction paths now document and test zero-based array indexing:
$[0]$.a[1].bTesting
Expanded
VariantUtilsTestcoverage includes:FLOAT32andFLOAT64Validation results:
VariantUtilsTest: 32 tests, 0 failures, 0 errorsChecklist