Skip to content

Remove Arrow C++ dependency from C++ tests - #23708

Draft
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/arrow-c-test-producer
Draft

Remove Arrow C++ dependency from C++ tests#23708
vyasr wants to merge 1 commit into
NVIDIA:mainfrom
vyasr:codex/arrow-c-test-producer

Conversation

@vyasr

@vyasr vyasr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the Arrow C++ fetch/link from C++ test configuration
  • stop compiling the legacy Arrow C++ interop test sources while keeping the nanoarrow host/device/stream coverage
  • add a small direct Arrow C host producer test for from_arrow_host
  • replace the Arrow tdigest oracle in percentile_approx_text coverage with fixed gold cases

Resolves #23445

Validation

  • configure-cudf-cpp
  • cmake --build cpp/build/conda/cuda-12.9/release --target INTEROP_TEST QUANTILES_TEST -j4
  • ./INTEROP_TEST --gtest_filter=FromArrowHostDeviceTest.DirectArrowCProducerTable
  • ./QUANTILES_TEST --gtest_filter=PercentileApproxTest.ReductionGold:PercentileApproxTest.GroupByGold:PercentileApproxTest.GroupByWithNullsGold
  • { ldd INTEROP_TEST; ldd QUANTILES_TEST; } | grep -i arrow || true produced no output
  • git diff --check

@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vyasr
vyasr force-pushed the codex/arrow-c-test-producer branch from fab9f4b to 2c3e2aa Compare August 18, 2026 18:49
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Aug 18, 2026
@vyasr
vyasr force-pushed the codex/arrow-c-test-producer branch from 2c3e2aa to 3aab9f6 Compare August 18, 2026 21:14
@vyasr

vyasr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

/ok to test

@vyasr, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@vyasr vyasr added tests Unit testing for project improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 18, 2026
@vyasr
vyasr force-pushed the codex/arrow-c-test-producer branch from 3aab9f6 to 59d5d24 Compare August 18, 2026 21:24
@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr

vyasr commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Support a mirror base URL for Arrow bundled Thrift downloads

1 participant