Replace prefetch_file_metadata's bool/Unspecified with explicit remote_only/always/never - #23699
Draft
Matt711 wants to merge 1 commit into
Draft
Replace prefetch_file_metadata's bool/Unspecified with explicit remote_only/always/never#23699Matt711 wants to merge 1 commit into
prefetch_file_metadata's bool/Unspecified with explicit remote_only/always/never#23699Matt711 wants to merge 1 commit into
Conversation
…e_only/always/never values
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Matt711
added
improvement
github-actions
Bot
added
Python
Member
Author
|
/ok to test aafa183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #23558 / #23684. Replaces the type of
ParquetOptions.prefetch_file_metadata(ie. bool/Unspecified) withLiteral["remote_only", "always", "never"]so it's serializable. The env var still accepts "1"/"0" etc. for backwards compatibility. Our plan is eventually turn on metadata prefetching on by default which would eliminate need forLiteral["remote_only", "always", "never"](on/off would be sufficient).Checklist