Skip to content

Disable join filter pushdown rewrites by default #23407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Jul 23, 2026
Merged

Disable join filter pushdown rewrites by default #23407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/cudf_polars/cudf_polars/utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,9 @@ class StreamingExecutor:
Options controlling the logical join-domain prefilter rewrite. See
:class:`~cudf_polars.utils.config.JoinFilterPushdownOptions` for more.
``None`` disables the rewrite.

Enable through environment variables with
``CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN=1``.
max_io_threads
Maximum number of IO threads. Default is 4.
This controls the parallelism of IO operations when reading data.
Expand Down Expand Up @@ -1102,7 +1105,7 @@ def from_polars_engine(
)
if user_join_filter_pushdown is None:
env_join_filter_pushdown = os.environ.get(
"CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN", "1"
"CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN", "0"
)
if not _bool_converter(env_join_filter_pushdown):
user_executor_options["join_filter_pushdown"] = None
Expand Down
6 changes: 3 additions & 3 deletions python/cudf_polars/tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,9 +615,7 @@ def test_dynamic_planning_defaults() -> None:
assert config.executor.dynamic_planning.join_prefilter_threshold == 0.5
assert config.executor.dynamic_planning.join_prefilter_max_key_columns == 1
assert not config.executor.dynamic_planning.join_prefilter_trace
assert config.executor.join_filter_pushdown is not None
assert config.executor.join_filter_pushdown.threshold == 0.5
assert not config.executor.join_filter_pushdown.trace
assert config.executor.join_filter_pushdown is None


def test_dynamic_planning_disabled_from_env(monkeypatch: pytest.MonkeyPatch) -> None:
Expand All @@ -642,6 +640,7 @@ def test_dynamic_planning_sample_chunk_count_from_env(


def test_join_prefilter_options_from_env(monkeypatch: pytest.MonkeyPatch) -> None:
monkeypatch.setenv("CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN", "1")
monkeypatch.setenv(
"CUDF_POLARS__EXECUTOR__DYNAMIC_PLANNING__JOIN_PREFILTER_THRESHOLD", "0.25"
)
Expand All @@ -665,6 +664,7 @@ def test_join_prefilter_options_from_env(monkeypatch: pytest.MonkeyPatch) -> Non
def test_join_filter_pushdown_options_from_env(
monkeypatch: pytest.MonkeyPatch,
) -> None:
monkeypatch.setenv("CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN", "1")
monkeypatch.setenv(
"CUDF_POLARS__EXECUTOR__JOIN_FILTER_PUSHDOWN__THRESHOLD", "0.125"
)
Expand Down
Loading