review: Preserve valid false-positive adjudications#38
Merged
Conversation
The findings validator required models to copy each protected finding and its problem text exactly into every KEEP/DROP decision. Correct DROP decisions were discarded when a model omitted incidental metadata such as a location, causing boro to fall back to both the protected baseline and raw regular findings. Identify each KEEP/DROP decision by its baseline ID and keep the original baseline finding in boro. Require the compact schema directly, while retaining strict verdict, proof, ordering, and deterministic upstream-fix checks. If baseline proof formatting still fails, salvage an independently empty regular-candidate decision instead of resurrecting disproved candidates. Also require caller-first lifecycle analysis for NULL, publication, initialization, teardown, and lifetime findings, with regression coverage for the observed failure mode. This allows boro to reliably drop validated false positives while reducing duplicated tokens and avoiding costly retries caused by irrelevant differences in copied finding metadata. Signed-off-by: Andrea Righi <arighi@nvidia.com>
arighi
force-pushed
the
preserve-false-positive-adjudications
branch
from
July 22, 2026 08:27
bb51ed4 to
7a2b170
Compare
nirmoy
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The findings validator required models to copy each protected finding and its problem text exactly into every KEEP/DROP decision. Correct DROP decisions were discarded when a model omitted incidental metadata such as a location, causing boro to fall back to both the protected baseline and raw regular findings.
Identify each KEEP/DROP decision by its baseline ID and keep the original baseline finding in boro. Require the compact schema directly, while retaining strict verdict, proof, ordering, and deterministic upstream-fix checks.
If baseline proof formatting still fails, salvage an independently empty regular-candidate decision instead of resurrecting disproved candidates. Also require caller-first lifecycle analysis for NULL, publication, initialization, teardown, and lifetime findings, with regression coverage for the observed failure mode.
This allows boro to reliably drop validated false positives while reducing duplicated tokens and avoiding costly retries caused by irrelevant differences in copied finding metadata.