review: Generalize the findings validator across targets#36
Merged
arighi merged 1 commit intoJul 15, 2026
Merged
Conversation
The shared findings-validation prompt instructed every target to check Kbuild ownership and reason about EXPORT_SYMBOL() loadable-module boundaries. Those are kernel-only concepts, so a libvirt or QEMU review was handed kernel-specific linkage rules that do not apply. Generalize resources/review-validation-findings.md to a domain-neutral linkage rule (verify against the project's build system and aggregator sources) and move the kernel-specific Kbuild/EXPORT_SYMBOL guidance into a dedicated addendum (resources/review-validation-findings-kernel.md), re-attached only for ReviewTarget::Kernel via a new TargetSpec::validation_findings_addendum() hook. Kernel reviews keep the exact same validator text; non-kernel targets get only the neutral base. Add a regression test asserting the separation. Signed-off-by: Nathan Chen <nathanc@nvidia.com>
NathanChenNVIDIA
force-pushed
the
generalize-findings-validator
branch
from
July 14, 2026 00:58
71986bf to
67df499
Compare
arighi
approved these changes
Jul 15, 2026
arighi
left a comment
arighi
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared findings-validation prompt instructed every target to check Kbuild ownership and reason about EXPORT_SYMBOL() loadable-module boundaries. Those are kernel-only concepts, so a libvirt or QEMU review was handed kernel-specific linkage rules that do not apply.
Generalize resources/review-validation-findings.md to a domain-neutral linkage rule (verify against the project's build system and aggregator sources) and move the kernel-specific Kbuild/EXPORT_SYMBOL guidance into a dedicated addendum (resources/review-validation-findings-kernel.md), re-attached only for ReviewTarget::Kernel via a new TargetSpec::validation_findings_addendum() hook. Kernel reviews keep the exact same validator text; non-kernel targets get only the neutral base. Add a regression test asserting the separation.