review: Suppress validated false positives from LKML reviews#35
Merged
Conversation
Require the strong validation stage to independently adjudicate every baseline finding before LKML rendering. Each finding must receive an exact, ordered KEEP or DROP decision with structured proof backed by repository inspection. Reject incomplete or mismatched adjudications and preserve the baseline on validation or tool-verification failure. Apply DROP only when the validator copies the complete finding and conclusively proves it's a false positive. Keep deterministic upstream-fix findings unconditionally. This improves the signal-to-noise ratio of LKML-style reviews by suppressing findings that have been conclusively proven to be false positives while reporting all validated findings. Signed-off-by: Andrea Righi <arighi@nvidia.com>
arighi
force-pushed
the
reduce-false-positives
branch
from
July 15, 2026 17:24
d154bd4 to
9bbdce7
Compare
Collaborator
Author
|
I've been testing this extensively with positive results, I think we can safely merge it at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require the strong validation stage to independently adjudicate every baseline finding before LKML rendering. Each finding must receive an exact, ordered KEEP or DROP decision with structured proof backed by repository inspection.
Reject incomplete or mismatched adjudications and preserve the baseline on validation or tool-verification failure. Apply DROP only when the validator copies the complete finding and conclusively proves it's a false positive. Keep deterministic upstream-fix findings unconditionally.
This improves the signal-to-noise ratio of LKML-style reviews by suppressing findings that have been conclusively proven to be false positives while reporting all validated findings.