feat: VDB operator entry-point registry for service-mode fluent ingestor - #2383
Draft
jdye64 wants to merge 1 commit into
Draft
feat: VDB operator entry-point registry for service-mode fluent ingestor#2383jdye64 wants to merge 1 commit into
jdye64 wants to merge 1 commit into
Conversation
Implement Option A: third-party packages register custom vector database backends via the nemo_retriever.vdb_operators setuptools entry-point group. get_vdb_op_cls() and list_vdb_ops() merge built-in lancedb with discovered entry points. Service-mode policy gains pipeline_overrides.allowed_vdb_ops so operators can permit specific vdb_op values from fluent ServiceIngestor.vdb_upload(). Connection URI validation is backend-neutral (uri, lancedb_uri, host, url). Includes tests and VDB package README documentation. Co-authored-by: Jeremy Dyer <jdye64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Option A: a setuptools entry-point registry so third-party packages can register custom vector database backends and select them from the fluent ingestor in service run mode.
Changes
factory.py:get_vdb_op_cls()andlist_vdb_ops()merge built-inlancedbwith backends registered under thenemo_retriever.vdb_operatorsentry-point group. Addsextract_vdb_connection_uri()for backend-neutral URI validation.policy.py: Newallowed_vdb_opspolicy gate; generalized connection URI checks;registered_vdb_opsexposed viapipeline-configintrospection.config.py/retriever-service.yaml:pipeline_overrides.allowed_vdb_ops(default:[lancedb]).ServiceIngestor.vdb_upload(): Accepts customvdb_opvalues and generic connection URI fields (host,url, etc.).tests/test_vdb_factory.py(62 related tests passing locally).common/vdb/README.mdwith registration and service-mode usage.Register a custom backend
Install the package on worker pods, then configure the service:
Client usage:
Test plan
pytest tests/test_vdb_factory.py tests/test_service_sinks.py tests/test_nv_ingest_vdb_operator.py