fix(libsy): stop reading source text as a runtime failure - #568
Draft
ryan-lempka wants to merge 4 commits into
Draft
fix(libsy): stop reading source text as a runtime failure#568ryan-lempka wants to merge 4 commits into
ryan-lempka wants to merge 4 commits into
Conversation
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
|
…detection Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
Signed-off-by: Ryan Lempka <rlempka@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: Stage routing scores severity by pattern-matching the text a tool returns. Three matches fire on text that is not an error. Severity forces the capable tier ahead of every other rule, and a failure literal vetoes test-pass detection (e.g. exit code 0), so both block de-escalation.
libsyhas a module namederror, so passing tests printtest error::tests::.... Any repo with anerrormodule cannot detect a greencargo test.Both failures are silent: routing returns 200 and the cheap tier stops being used.
What: Both in
crates/libsy/src/algorithms/util/tool_signals.rs.reports_no_failureskips severity scoring when a tool result reports exit 0, or the command is still running.contains_failure_literalstopserror:matching the patherror::.Why: Status code should be trusted over text matching and we should not treat messages from source text reading as a runtime error.