fix: log exceptions instead of silently swallowing them in Job/JobGroup.status#569
Open
andrewwhitecdw wants to merge 1 commit into
Conversation
…up.status Job.status and JobGroup.status used with a , which swallowed status-check failures silently and made debugging hard. Preserve the existing fallback behavior (return last known state / UNKNOWN) but log the exception at ERROR level so operators can see when the runner is failing. Updates existing exception tests to assert the error is logged. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Job.statusandJobGroup.statususedexcept Exception: ...with afinally: return, which swallowed status-check failures silently and made debugging hard.Fix
Preserve the existing fallback behavior (return last known state / UNKNOWN) but log the exception at ERROR level so operators can see when the runner is failing.
Test
Updated
test_job_status_exceptionandtest_job_group_status_exceptionto assert the error is logged usingcaplog.Verification
uv run pytest test/run/test_job.py::test_job_status_exception test/run/test_job.py::test_job_group_status_exception -vpasses.uv run --group lint ruff check ...andruff format --check ...pass.