Hide Health Check URL field on the kiosk enrollment form - #208
Draft
sdunster wants to merge 1 commit into
Draft
Conversation
Add a showHealthcheckUrl prop to SessionForm (default true) and set it to false in SessionEnroll, since the kiosk isn't provisioned yet at that point and the field can be set later from the session edit page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0121rQfh6dajppxnhJRCwRFu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showHealthcheckUrlprop toSessionForm(defaulttrue) that controls whether the Health Check URL field is renderedshowHealthcheckUrl={false}inSessionEnroll.tsx(the QR-code kiosk enrollment form), since the kiosk isn't provisioned yet at that point and the URL can be set later from the session's edit pageSessionsNew.tsxandSessionsEdit.tsxdon't pass the prop, so the field stays visible everywhere elseTest plan
npx tsc -binweb/npx eslinton the changed filesnpx prettier --checkon the changed files🤖 Generated with Claude Code
https://claude.ai/code/session_0121rQfh6dajppxnhJRCwRFu
Generated by Claude Code