Update release notes for OLIDS repos to release v2.3.0 - #112
Open
BillWoodNHS wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the consolidated OLIDS release-notes index and adds new release-note pages to document the latest versions for OLIDS_Share, EMIS_OLIDS, and OLIDS_Enrichment.
Changes:
- Updated
OLIDS/Release-notes/README.mdto point “Latest releases” at the new versions. - Added release notes for
OLIDS_Sharev1.4.0,EMIS_OLIDSv2.3.0, andOLIDS_Enrichmentv2.3.0. - Included PR/work item traceability links and compare links for each release.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OLIDS/Release-notes/README.md | Updates “Latest releases” links to the new release-note pages. |
| OLIDS/Release-notes/1_OLIDS_Share/v1.4.0.md | Adds release notes for OLIDS_Share v1.4.0. |
| OLIDS/Release-notes/2_EMIS_OLIDS/v2.3.0.md | Adds release notes for EMIS_OLIDS v2.3.0. |
| OLIDS/Release-notes/3_OLIDS_Enrichment/v2.3.0.md | Adds release notes for OLIDS_Enrichment v2.3.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…TIENT_AGE_FLAGS table docs
…ISL/Datasets into olids/release-notes-20260805
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.
Suppressed comments (9)
OLIDS/Documentation/Schema/Medication_Statement.md:62
- In this table, rows without a PK/FK value leave the PK/FK cell empty (see surrounding rows).
LDS_SOURCE_DATASETcurrently uses-in the PK/FK column, which is inconsistent.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- |
OLIDS/Documentation/Schema/Schedule.md:39
- This table uses empty PK/FK + Masking Policy cells and
--for missing Compass mappings (see nearby rows). TheLDS_SOURCE_DATASETrow currently uses placeholder values (-,--,-) that are inconsistent with the rest of the table and imply a masking policy of--.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- | - |
OLIDS/Documentation/Schema/Patient_Address.md:43
- This 6-column schema table leaves PK/FK and Masking Policy empty when not applicable (and uses
--for missing Compass mappings). TheLDS_SOURCE_DATASETrow currently uses placeholder values (-,--,-) that don’t match the established pattern in this table.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- | - |
OLIDS/Documentation/Schema/Appointment.md:65
- In this 6-column schema table, the
LDS_SOURCE_DATASETrow only has 5 cells, so it won’t align/render consistently with the rest of the table (missing the Masking Policy cell). Add an empty Masking Policy cell and keep Compass Equivalent as--when there is no mapping.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- |
OLIDS/Documentation/Schema/Patient_Contact.md:33
- This 6-column schema table leaves PK/FK and Masking Policy empty when not applicable (and uses
--for missing Compass mappings). TheLDS_SOURCE_DATASETrow currently uses placeholder values (-,--,-) that don’t match the pattern used by other rows in the same table.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- | - |
OLIDS/Documentation/Schema/Patient_Person.md:27
- In this 6-column schema table, the
LDS_SOURCE_DATASETrow uses placeholder values (-,--,-) in PK/FK / Masking Policy / Compass Equivalent, but surrounding rows use blank PK/FK + Masking Policy cells and--where there is no Compass mapping.
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- | - |
OLIDS/Documentation/Schema/Patient.md:67
LDS_SOURCE_DATASETis listed twice in the columns table, which makes the schema ambiguous. Consolidate to a single row (and keep the PK/FK + Masking Policy cells empty, consistent with other non-key rows).
| `LDS_SOURCE_DATASET` | `VARCHAR` | name of the source dataset | | | -- |
| `LDS_IS_DELETED` | `BOOLEAN` | lds is deleted. | | | -- |
| `PUBLISHER_ORGANISATION_CODE` | `VARCHAR` | The Organisation Data Service (ODS) code of the organisation who, acting as the data controller, publishes the |data. | | `organization_id` |
| `SOURCE_EXTRACTION_DATE` | `TIMESTAMP` | source extraction date. | | | -- |
| `LDS_SOURCE_DATASET` | `VARCHAR` | The name of the source dataset (or system) that the record is obtained from | - | -- | - |
OLIDS/Documentation/Schema/Patient_Age_Flags.md:18
- The FK link formatting here is inconsistent with other schema docs (e.g.
FK -> [Patient](Patient.md).IDin Medication_Statement.md) and the uppercase link text is unusual. Using the same spacing/casing improves readability and consistency.
| `ID` | `UUID` | The Patient ID | FK ->[PATIENT](Patient.md).ID | - | - |
OLIDS/Documentation/Schema/Medication_Statement.md:41
CANCELLATION_DATEuses-as the “no mapping” marker in the Compass Equivalent column, but other rows in this table use--. This makes the table inconsistent and may be misread as a real value.
This issue also appears on line 62 of the same file.
| `CANCELLATION_DATE` | `DATE` | supplied cancellation date. | | - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release notes for the OLIDS projects to document the latest versions and their key changes. It adds new release documentation for:
OLIDS_Sharev1.4.0,EMIS_OLIDSv2.3.0, andOLIDS_Enrichmentv2.3.0,and updates the main README to reference these new releases. The release notes highlight major new features, bug fixes, and improvements across the projects.
Release notes and documentation updates
OLIDS_Sharev1.4.0, detailing the introduction of a sharedformat_postcodemacro for standardized postcode formatting and repository cleanup.EMIS_OLIDSv2.3.0, documenting a critical fix in patient deduplication logic for NHS number placeholders, new unit tests, and an update to useOLIDS_Sharev1.4.0.OLIDS_Enrichmentv2.3.0, describing enhancements to NDOO request handling, addition of derived cancellation dates, improved source dataset tracking, table clustering, standardized age flag logic, and package updates.OLIDS/Release-notes/README.md) to point to the latest release documentation for all three projects.