Make constituent index lookup routines case insensitive - #765
Merged
Conversation
climbfuji
approved these changes
Jul 10, 2026
Collaborator
Author
|
Could one of you take a look at this? I know it's in v0 so it's not critical to y'all, but I'd like to get it in soon-ish |
dustinswales
approved these changes
Jul 15, 2026
Collaborator
|
@peverwhee Please go ahead and merge whenever you are ready. |
climbfuji
added a commit
that referenced
this pull request
Jul 16, 2026
Format update of `feature/capgen-v1` from `develop` to resolve conflicts after merging #765 into develop / #767 into `feature/capgen-v1`. There's a small leftover change in `end-to-end-tests/advection_auto_clone/cld_liq.F90` that was made in #765 but not in #767. The other test data change in `test/advection_test/test_host_data.F90` (see https://github.com/NCAR/ccpp-framework/pull/765/changes#diff-04bf1167afd493d2ea37bd03d093e200ba8b563383bfd1cca3fc9126aca9c4a9) is already in `feature/capgen-v1`. Co-authored-by: Courtney Peverley <courtneyp@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
to_lowerroutine toccpp_constituent_prop_mod.F90and uses that to make theccpp_constituent_index,ccpp_constituent_indices, and<host>_const_get_indexinterfaces case-insensitive.Also removes redundant routine in scripts/host_cap.py
User interface changes?: No
Testing: 2 small mods to check case insensitivity in advection test.