Build linux wheels on manylinux_2_28 to match numpy - #2
Merged
Conversation
The 3.2.0 release pipeline failed building linux wheels. The wheel itself built fine; cibuildwheel's test step then installed it inside the build container and could not resolve numpy. cibuildwheel defaults to manylinux2014 (glibc 2.17), and numpy has stopped shipping manylinux2014 wheels: from 2.5 it publishes manylinux_2_28 and musllinux_1_2 only. pip therefore fell back to the numpy sdist and tried to compile it, which cannot work in that image, since it ships GCC 10.2.1 and numpy requires 10.3 or newer. Pins the linux images to numpy's own floor. Being more permissive than numpy gained nothing: LZGraphs does not run without numpy, so a glibc 2.17 wheel is one whose dependency will not resolve on the machine that can install it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.2.0 release pipeline failed at
build_wheels (ubuntu-latest, x86_64 aarch64). Nothing was published: PyPI, GHCR and the GitHub Release all correctly skipped.The wheel built fine. cibuildwheel's test step then installed it inside the build container and could not resolve numpy:
cibuildwheel defaults to manylinux2014 (glibc 2.17). numpy 2.5 ships only
manylinux_2_28andmusllinux_1_2wheels, so pip fell back to the sdist and tried to compile it, in an image with GCC 10.2.1.Pins the linux images to numpy's own floor. Being more permissive than numpy gained nothing here: LZGraphs does not run without numpy, so a glibc 2.17 wheel is one whose dependency will not resolve on the machine that can install it. macOS and Windows wheels were unaffected and already passed.