fix: "Type 'Null' is not a subtype of type 'List<dynamic>'" exception

[sebipirpi]

Problem
When retrieving the images for catalog products, an exception is thrown because the "related_objects" field is not expected to be nullable. However, in my case, it is missing from the response entirely. This is reproducible via the Rest API as well, when sending a GET request http://connect.squareupsandbox.com/v2/catalog/object/{id} for an image for example.

Fix
Make the "related_objects" field nullable in the responses for "retrieve_catalog_objects" and "batch_retrieve_catalog_objects".

[sebipirpi]

@mtwichel can you please review this when you have time?

[sebipirpi]

@fabriziocacicia @BruceClark406 could you please take a look at this?

[mtwichel]

Looks good, thanks for the contribution!

[sebipirpi]

@mtwichel one of the checks fails because of a method that I didn't touch as far as I can tell, more specifically "_$BatchRetrieveCatalogObjectsRequestFromJson". The line length exceeds 80 characters where it's declared. Should I rename it?

[mtwichel]

@mtwichel one of the checks fails because of a method that I didn't touch as far as I can tell, more specifically "_$BatchRetrieveCatalogObjectsRequestFromJson". The line length exceeds 80 characters where it's declared. Should I rename it?

Looks like it just failed the formatter. Could you try running dart format . in the root of the repository? That should fix it up.

[sebipirpi]

@mtwichel one of the checks fails because of a method that I didn't touch as far as I can tell, more specifically "_$BatchRetrieveCatalogObjectsRequestFromJson". The line length exceeds 80 characters where it's declared. Should I rename it?

Looks like it just failed the formatter. Could you try running dart format . in the root of the repository? That should fix it up.

Done, thanks.

[sebipirpi]

@mtwichel is there anything else I can do on my part? From what I can see, this check has failed for other PRs as well.

[sebipirpi]

@mtwichel could you please take a look when you have time?