Skip to content

Keep resumed chats on their saved sandbox - #343

Merged
charlesrhoward merged 1 commit into
mainfrom
fix/native-chat-resume-sandbox
Aug 30, 2026
Merged

Keep resumed chats on their saved sandbox#343
charlesrhoward merged 1 commit into
mainfrom
fix/native-chat-resume-sandbox

Conversation

@charlesrhoward

@charlesrhoward charlesrhoward commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • let resumed native chats use their persisted, owned sandbox when the browser still has a different sandbox selected
  • keep browser sandbox hints non-authoritative and cover the stale-hint case with a regression test

Privacy and compatibility

No schema or public API changes. Existing conversation ownership, repository ownership, and saved-sandbox validation remain enforced.

Verification

  • focused native chat route and context tests
  • ESLint (zero errors)
  • TypeScript typecheck
  • diff whitespace check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@mogplex

mogplex Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Mogplex PR Review

Status: No material issues found

Summary: The implementation matches the PR description: a stale browser-provided sandbox hint no longer prevents a resumed native chat from loading its persisted sandbox. Existing conversation ownership, repository scope, sandbox ownership, and sandbox/repository consistency checks remain intact.

Critical issues: None.

Warnings: None. The updated unit test verifies that the persisted sandbox is loaded and that its workspace and branch context are returned instead of the stale hint.

Suggestions: None.

Verdict: ✅ APPROVE — The change is narrowly scoped, preserves server-authoritative validation, and includes appropriate regression coverage.

View check run

@charlesrhoward
charlesrhoward added this pull request to the merge queue Aug 30, 2026
Merged via the queue into main with commit 2a00194 Aug 30, 2026
17 of 19 checks passed
@charlesrhoward
charlesrhoward deleted the fix/native-chat-resume-sandbox branch August 30, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant