Keep resumed chats on their saved sandbox - #343
Merged
Conversation
charlesrhoward
enabled auto-merge
August 30, 2026 19:33
Contributor
Mogplex PR ReviewStatus: No material issues found Summary: The implementation matches the PR description: a stale browser-provided sandbox hint no longer prevents a resumed native chat from loading its persisted sandbox. Existing conversation ownership, repository scope, sandbox ownership, and sandbox/repository consistency checks remain intact. Critical issues: None. Warnings: None. The updated unit test verifies that the persisted sandbox is loaded and that its workspace and branch context are returned instead of the stale hint. Suggestions: None. Verdict: ✅ APPROVE — The change is narrowly scoped, preserves server-authoritative validation, and includes appropriate regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Privacy and compatibility
No schema or public API changes. Existing conversation ownership, repository ownership, and saved-sandbox validation remain enforced.
Verification
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.