fix(web): close webview for page-opening mixin schemes#6482
Open
SeniorZhai wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds conditional source-WebActivity closure when Mixin redirects open full-page destinations, while preserving bottom-sheet flows.
Changes:
- Classifies page-opening Mixin redirects.
- Propagates closure intent through URL routing.
- Adds redirect-classification tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
WebFragment.kt |
Classifies main-frame redirects requiring closure. |
UrlExtension.kt |
Propagates closure behavior through URL handlers. |
LinkBottomSheetDialogFragment.kt |
Closes source WebActivity after page navigation. |
WebFragmentRedirectTest.kt |
Tests page versus bottom-sheet classification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| AnalyticsTracker.trackOpenBotHomePage(AnalyticsTracker.BotSource.SCHEME, app.appNumber) | ||
| WebActivity.show(requireActivity(), url, null, app) | ||
| closeSourceWebActivityOnOpenPage() |
Comment on lines
+295
to
+297
| if (closeSourceOnOpenPage) { | ||
| closeSourceWebActivityIfNeeded(context) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test