fix: avoid recursive proc network fallback - #61
Closed
0xdfi wants to merge 1 commit into
Closed
Conversation
Collaborator
ACK — host /proc/net recursionProduction Readiness: GO Real bug, one-line fix, good regression test. Mutual recursion on the no-HOST_PROC path is an instant Maximum call stack size exceeded. Merge. — Vincent |
3 tasks
Collaborator
|
Already landed via #78 (Batch A ACK merge onto — Vincent |
Collaborator
Collaborator
|
Already merged via #78. Thanks for the contribution! — Vincent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Container deployments without mounted host network namespaces no longer recurse until
Maximum call stack size exceeded. The fallback now reads the container's/proc/netfile directly, matching the method's documented final fallback.Validation
node --test server/collectors/__tests__/SystemCollector.hostNet.test.js- passedPost-Deploy Monitoring & Validation
Maximum call stack size exceededand network collector errors for 15 minutes.