refactor: bridge QuoteMetadata read/write#9507
Open
micaelae wants to merge 8 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9afe7b6. Configure here.
| const l1GasFeesInDecGWei = weiHexToGweiDec(toHex(l1GasFeesInHexWei ?? '0')); | ||
| const gasFeesInDecGwei = totalGasLimitInDec | ||
| .times(feePerGasInDecGwei ?? '0') | ||
| ?.times(feePerGasInDecGwei ?? '0') |
There was a problem hiding this comment.
Missing trade gas crashes fee
High Severity
When tradeGasLimit is missing or zero, calcTotalGasFee leaves totalGasLimitInDec undefined, then optional chaining on times yields undefined and the following .plus(l1GasFeesInDecGWei) runs on undefined, which throws. Approval-only gas and L1 fees are also skipped instead of being summed like before.
Reviewed by Cursor Bugbot for commit 9afe7b6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
References
Checklist
Note
High Risk
Declared breaking API and behavior changes to fee/metadata shapes affect swap/bridge quote display, sorting, balance checks, and analytics; clients must upgrade optional access patterns.
Overview
BREAKING:
QuoteMetadataand nestedTokenAmountValuesare nowDeepPartial, and fee helpers stop coercing missing inputs to"0"ornull—undefined fields stay undefined. Consumers must use optional chaining (as inbridge-status-controller) and may see different UI when gas or rate data is incomplete.Quote metadata logic moves out of
selectors.tsintoutils/quote-metadata.ts(calcQuoteMetadata,mergeQuoteMetadata).selectBridgeQuotesWithMetadatacalls those instead of inlining calculations;QuoteMetadata/TokenAmountValuesare exported from the new module rather thantypes.ts. Sorting and metrics paths use safer access (e.g.quote?.cost?.valueInCurrency).bridge-status-controllertests and utils adoptmergeQuoteMetadatato attach metadata to quote fixtures and align history/metrics/snaps with optional metadata fields.Reviewed by Cursor Bugbot for commit 9afe7b6. Bugbot is set up for automated code reviews on this repo. Configure here.