Defi controller v2#9503
Open
bergarces wants to merge 19 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 06e53d3. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Checklist
Note
Medium Risk
New persisted DeFi state and balance/valuation logic affect portfolio display; v6 API and CAIP account matching must stay correct across EVM and Solana, but changes are additive alongside the legacy controller with solid test coverage.
Overview
Introduces
DeFiPositionsControllerV2, a parallel path to the legacy DeFi positions controller that loads positions from the Accounts API v6 multiaccount balances endpoint and keeps them inallDeFiPositionsV2keyed by internal account ID (not address), in a shape the DeFi tab can read without extra grouping.fetchDeFiPositionsresolves accounts from the selected account group, builds the v6 query viabuildDeFiBalancesQuery(first EVM + first Solana in the group, fixed supported networks, DeFi + prices flags), callsfetchV6MultiAccountBalances, maps per-chain CAIP-10 IDs back to internal IDs, and runsgroupDeFiPositionsV6into protocol groups with embedded detail sections, fiatmarketValue(lendingtreated as a liability), and token icons. Fetches are gated byisEnabled, skip unsupported-only groups, and are throttled in-memory per account set (cleared on failure); analytics from the old controller are intentionally not ported yet.@metamask/core-backendnow exportsV6_DEFI_POSITION_TYPES/V6DeFiPositionTypeand typesV6BalanceMetadata.positionTypeaccordingly. Public exports include controller state/types,DEFI_POSITION_LIABILITY_TYPES, query helpers, and messenger action types. Unit tests cover query building, grouping, and controller behavior; a localdefi-visualizer.htmlhelps inspect API responses.Reviewed by Cursor Bugbot for commit 5cb1671. Bugbot is set up for automated code reviews on this repo. Configure here.