CI: exclude thirdparty/licenses from docker image source checksums#6447
Open
Grantim wants to merge 1 commit into
Open
CI: exclude thirdparty/licenses from docker image source checksums#6447Grantim wants to merge 1 commit into
Grantim wants to merge 1 commit into
Conversation
License texts are shipped inside packages, not baked into the images, so a licenses-only commit should not move the source-checksum-* tag and trigger a needless full rebuild of every image. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6436, reopening the change from the closed #6437 against the merged registry-check mechanism.
thirdparty/licenses/**— the curatedTHIRD-PARTY-NOTICES.txtand itsmanifest.json— is currently hashed into every image'ssource-checksum-*tag, yet none of it reaches the images: the license texts are copied into the distributed packages, not into the build environment. So a licenses-only commit moves the checksum tag, and under #6436 that tag then resolves to no image in the registry, forcing a full rebuild of every distro image for a change that alters nothing in them.This excludes the directory from the hashed set, matching the existing exclusions for
Noto_Sans,mrbind, andvcpkg.Effect
Verified locally
ubuntu24:source-checksum-a600c4fdf24cd22e→source-checksum-22cb33e3f998330a, and the only paths leaving the hashed set arethirdparty/licenses/THIRD-PARTY-NOTICES.txtandthirdparty/licenses/manifest.json— no collateral.