fix(review): resolve the still-valid review findings on #899

[Akarsh-Hegde]

Triage of the 28 inline review comments on #899 (pre-main → main, v1.91.0). Fixes land here because nothing may be pushed to pre-main directly; #899 picks them up on its next sync.

Most comments were written on 2026-08-25/26 against a pre-main that has since moved ~40 commits. Clerk was replaced by the OTP capture (c9f15596) and the PM-sync outbox was reverted (#912), so ten findings point at files that no longer exist.

Fixed

Finding	What changed
src/llm/detect.rs logged raw CLI output (🔒 Major)	raw_tail = %reason → raw_tail_len + crash_class. DEBUG is off by default so it rarely captures, but when it does it lands in the telemetry spool, and an Export Diagnostics bundle ships the spool unredacted to support. That branch's own comment says a device code or OAuth URL can be the only thing in the tail.
startup_health.rs had no tracing	fast_poll_until_healthy did real work with no span and no outcome logs, so a stale offline banner left no record of which exit it took. Instrumented: healthy / timeout / poisoned-lock / failed-emit are now distinguishable, with elapsed cold-start time on the span.
whats_new.rs counted bytes, not chars	String::len() → .chars().count(). Latent today (the file is all-ASCII) — this is the fix before it bites.
CLAUDE.md said "at most three"	→ 1-3. The assertion also rejects an empty list.
WhatsNewModal key={item.title}	→ ${r.version}-${idx}. Note the review's cross-release claim is wrong (siblings are per-release), but two items in one release may share a title.
Em dash in the Jira bail!	→ plain hyphen. This one reaches the user on stdout.

Plus one red test already on pre-main, unrelated to the review: log_hygiene::no_user_data_interpolated_into_a_log_body was failing — the provider-unreachable WARN interpolated {streak} into its body, which ships verbatim to central OpenObserve. streak was already a structured field on the same call, so the body is now static. The pre-push hook runs the full suite, so this had to be fixed for anything to land.

Deliberately not done

• Migrations 082/083 (Copilot). The tables are inert, but sqlx::migrate! raises VersionMissing for an applied migration that has left the source tree. They shipped in v1.91.0-staging.2 onward, so removing them crash-loops every staging tester's daemon. Cost of keeping: zero. Cost of removing: a dead install.
• detect.rs (3355 lines) and tray lib.rs (1912 lines) splits. Real against the 500-line rule, but pre-existing and not a regression this release introduced. A release-PR review pass is the wrong place to restructure the daemon's LLM detection.
• Em dashes in log message bodies (main.rs, platform/unix.rs). There are 256 em dashes in Rust string literals, almost all log messages; CLAUDE.md's rule enumerates UI copy, notification bodies and tooltips, and exempts diagnostics. Fixing 3 of 256 is noise. (CodeRabbit marked this thread "✅ Addressed" while the strings are still present — the badge was not trusted for the behavioural findings either; the checkpoint pid, is_unprinted_attr exact-vs-prefix matching, and the bounded quit flush were each re-verified in the current tree.)
• Two whats-new.json fragment bodies (v1.75.0, v1.70.0). Historical entries users have already read; rewriting shipped release notes changes the record for no reader benefit.

Obsolete — files no longer exist

Both Clerk findings; pm_sync_requests/mod.rs, sync_delegate.rs, sync_requests.rs; the intelligence/mod.rs vacuous ordering test; the WorklogTicketPicker double-read (there is only one read() now).

Verification

cargo clippy --workspace --all-targets -D warnings clean · cargo test --workspace 1153+ pass, 0 fail · bun test 921 pass · npm run build clean.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 6f8924f2-8220-4682-b08d-de26b06c4e85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}