Fix plugins.qgis.org security-review findings#309
Merged
Conversation
Rename token_prefix -> bearer_prefix in decode_token_data so the "Bearer " scheme prefix no longer trips Bandit B105 (hardcoded password) - a critical, non-waivable finding that auto-rejects the bundled plugin on plugins.qgis.org. Suppress the three internal asserts with "# nosec B101" so they do not fail the review's Bandit check on a web upload.
Coverage Report for CI Build 29726781903Coverage remained the same at 83.395%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
MarcelGeo
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
token_prefix->bearer_prefixin decode_token_data so the "Bearer " scheme prefix is not catched by Bandit B105 (hardcoded password) - a critical, non-skippable finding that auto-rejects the bundled plugin on plugins.qgis.org.Suppress the three internal asserts with
# nosec B101so they do not fail the review's Bandit check on a web upload.