Skip to content

fix: return error for missing milestone contribution - #213

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
charlesedeh021-cell:fix/charles-milestone-refund-contribution-error
Aug 27, 2026
Merged

fix: return error for missing milestone contribution#213
chonilius merged 1 commit into
MergeFi:mainfrom
charlesedeh021-cell:fix/charles-milestone-refund-contribution-error

Conversation

@charlesedeh021-cell

Copy link
Copy Markdown
Contributor

Closes #106
Closes #105
Closes #104
Closes #103

Summary

  • Replaces the archived/missing contribution unwrap() in refund_remaining_budget with a typed contract error.
  • Prevents cancel_milestone from reaching a panic path when an expected contribution record is unavailable during proportional refunds.
  • Keeps existing refund math and storage layout unchanged.

Validation

  • Not run locally, per request.

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@charlesedeh021-cell is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@charlesedeh021-cell Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chonilius
chonilius merged commit 468dc3e into MergeFi:main Aug 27, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment