fix(escrow): replace panicking unwrap in refund's contribution loop - #211
Merged
chonilius merged 1 commit intoAug 28, 2026
Merged
Conversation
refund() looped over contributor_count and called .unwrap() on each Contribution read. A single missing/corrupted storage entry panicked the whole transaction (a host trap) instead of surfacing a typed error, with no path for the caller to detect or recover from it. Switched to .ok_or(Error::ContributionNotFound)? so the failure is a normal contract error like every other lookup in this module. Closes MergeFi#101 Closes MergeFi#131 Closes MergeFi#129 Closes MergeFi#132
|
@CelestinaBeing is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@CelestinaBeing Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escrow::refundlooped overcontributor_countand called.unwrap()on eachContributionstorage read. A single missing or corrupted contribution record panicked the entire transaction (a host trap) instead of returning a typed error, with no way for callers to detect or recover. Replaced with.ok_or(Error::ContributionNotFound)?, matching every other lookup in this contract.Closes #101
Closes #131
Closes #129
Closes #132