fix: improve persistent header and bottom nav contrast over frosted-glass backgrounds - #14
Merged
Merged
Conversation
Calibre's books/series tables have triggers calling title_sort() and uuid4() which Prisma's better-sqlite3 adapter doesn't register. Subclass PrismaBetterSqlite3 to register these functions on connect().
/api/{*path} is invalid in path-to-regexp v8.4.2. Use /api/*path instead.
…lass backgrounds - Bump header and bottom nav background opacity from bg-surface/95 to bg-surface/98 to reduce bright book cover bleed-through while preserving glassmorphism. - Switch nav link text, theme toggle, and logout button from text-on-surface-variant to text-on-surface for improved legibility in both light and dark themes. - Increase search icon opacity from 50% to 70% for better visibility. - Add unit tests verifying updated contrast classes on header, bottom nav, nav links, and theme toggle in both dark and light themes. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3: Persistent header and footer are hard to read due to frosted-glass translucency.
Problem
The persistent header and bottom navigation bar used frosted-glass translucency (
bg-surface/95+backdrop-blur) that let bright book covers bleed through the UI, makingtext-on-surface-variantnav icon/label text hard to read.Changes
frontend/layouts/default.vuebg-surface/95→bg-surface/98(reduces cover bleed-through while preserving glassmorphism)text-on-surface-variant→text-on-surface(higher contrast in both themes)text-on-surface-variant→text-on-surfacetext-on-surface-variant→text-on-surfacetext-on-surface-variant/50→text-on-surface-variant/70(increased opacity)frontend/layouts/default.spec.tsbg-surface/98andbackdrop-bluron header and bottom navtext-on-surfaceon all nav links and theme togglemountLayout()helperDesign Compliance
backdrop-blur-xl/backdrop-blur-mdretained)[data-theme=light]and default dark modeTest Results
All 75 tests pass across 9 test files.