Skip to content

chore: update master with rc1 - #3014

Open
rollandf wants to merge 1 commit into
Mellanox:masterfrom
rollandf:sync-rc1
Open

chore: update master with rc1#3014
rollandf wants to merge 1 commit into
Mellanox:masterfrom
rollandf:sync-rc1

Conversation

@rollandf

Copy link
Copy Markdown
Member

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown

Greptile Summary

The PR advances Network Operator and component release references from 26.7.0-beta.5 to 26.7.0-rc.1, including the previously stale Helm chart metadata.

  • Updates Helm chart metadata and default component image tags to rc.1.
  • Updates Kustomize init-container configuration and example NicClusterPolicy resources.
  • Updates the central release manifest, but leaves the generated OLM CSV labeled beta.5.

Confidence Score: 4/5

The PR is not yet safe to merge because its rc.1 release sources still produce a tracked OLM bundle identified as beta.5.

The Helm metadata is fixed, but the packaged ClusterServiceVersion retains the beta.5 name and spec.version, so publishing this commit's OLM bundle would misidentify the rc.1 release.

Files Needing Attention: hack/release.yaml and bundle/manifests/nvidia-network-operator.clusterserviceversion.yaml

Important Files Changed

Filename Overview
hack/release.yaml Advances release component versions to rc.1, but the corresponding tracked OLM CSV was not regenerated.
deployment/network-operator/Chart.yaml Correctly synchronizes both chart version and appVersion with v26.7.0-rc.1.
deployment/network-operator/values.yaml Consistently updates the changed default component image tags to the rc.1 release.
config/manager/init_container_image_name_patch.yaml Updates the Kustomize deployment's init-container image to rc.1.

Reviews (2): Last reviewed commit: "chore: update master with rc1" | Re-trigger Greptile

Comment thread hack/release.yaml
image: network-operator
repository: nvcr.io/nvstaging/mellanox
version: v26.7.0-beta.5
version: v26.7.0-rc.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Stale chart version mixes releases

When a Helm installation does not override operator.tag, the unchanged Chart.appVersion selects the beta.5 operator image while this release manifest and component defaults select rc.1, causing a mixed-version deployment and leaving generated Helm and OLM artifacts labeled beta.5.

Knowledge Base Used: Deployment and Manifests

Signed-off-by: Fred Rolland <frolland@nvidia.com>
Comment thread hack/release.yaml
@@ -8,21 +8,21 @@
NetworkOperator:
image: network-operator
repository: nvcr.io/nvstaging/mellanox

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 OLM bundle remains beta.5

When the OLM bundle is published for this rc.1 release, the unchanged ClusterServiceVersion still uses nvidia-network-operator.v26.7.0-beta.5 and version: 26.7.0-beta.5, causing OLM to identify the rc.1 artifact as the previous beta release.

Knowledge Base Used: Deployment and Manifests

@rollandf

Copy link
Copy Markdown
Member Author

/retest-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants