feat: add Rocky Linux support to state-OFED - #3012
Conversation
Greptile SummaryThis PR adds Rocky Linux support to state-OFED by reusing RHEL certificate-trust and yum-repository paths while intentionally omitting subscription-manager mounts.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the new Rocky configuration test now supplies both repository and certificate ConfigMaps and verifies their rendered mount destinations. Important Files Changed
Reviews (2): Last reviewed commit: "feat: add Rocky Linux support to state-O..." | Re-trigger Greptile |
| cr.Spec.OFEDDriver = &v1alpha1.OFEDDriverSpec{ | ||
| ImageSpec: v1alpha1.ImageSpec{ | ||
| Image: "mofed", | ||
| Repository: "nvcr.io/mellanox", | ||
| Version: "23.10-0.5.5.0", | ||
| }, | ||
| } |
There was a problem hiding this comment.
Rocky path mappings remain untested
The Rocky test leaves RepoConfig and CertConfig unset, so it bypasses both newly added path mappings and would not detect an invalid repository or certificate mount destination.
Knowledge Base Used: NicClusterPolicy Reconcile Flow
|
Hi @furlongm , is it a real use case? Do you have a cluster with Rocky OS that will need DOCA Ofed container? |
|
Yes, real use case. The current workaround for rocky nodes is to do the following on each node: and then add NFRs to spoof rocky as rhel: This PR removes the need for the workaround steps. |
|
@furlongm thanks for the response. |
|
Would it be possible to get the images published for Rocky? The GPU operator already publishes images for Rocky, e.g. https://catalog.ngc.nvidia.com/orgs/nvidia/-/containers/driver/580.173.02-rocky9 Seems like it would make sense to have the network operator publish Rocky images too? Currently, retagging the RHEL images works correctly as Rocky is RHEL-compatible (or you can use the NFR workaround to spoof the OS name). |
Rocky Linux is Red Hat Enterprise Linux compatible and uses the same cert trust store and yum repo directory layout. Add rocky entries to CertConfigPathMap and RepoConfigPathMap so state-OFED can render the doca-driver DaemonSet on Rocky nodes. Rocky has no subscription-manager equivalent so it is intentionally omitted from SubscriptionPathMap; users provide their own repo via NicClusterPolicy.spec.ofedDriver.repoConfig. Fixes: Mellanox#240 Signed-off-by: Marcus Furlong <furlongm@gmail.com>
db145d3 to
1b9f503
Compare
We will raise this question with Product Manager. |
Rocky Linux is Red Hat Enterprise Linux compatible and uses the
same cert trust store and yum repo directory layout. Add rocky
entries to CertConfigPathMap and RepoConfigPathMap so state-OFED
can render the doca-driver DaemonSet on Rocky nodes.
Rocky has no subscription-manager equivalent so it is
intentionally omitted from SubscriptionPathMap; users provide
their own repo via NicClusterPolicy.spec.ofedDriver.repoConfig.
Fixes: #240
Signed-off-by: Marcus Furlong furlongm@gmail.com