fix: Note fiter field hasn't a label - EXO-88599 - #1739
Merged
Conversation
Before this change, when access to note application and click on the fiter button, the filter field hasn't a label. After this change, aria-label=Filter by name, title=Filter by name and placeholder label to Start searching note page. (cherry picked from commit 85b5525)
|
ahamdi
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1734 to stable/7.2.x-exo.
Before this change, when accessing the note application and clicking the filter button, the filter field had no label. After this change: aria-label=
Filter by name, title=Filter by name, and placeholder=Start searching note page. The redundant custom tooltip is also removed since the native tooltip from the title attribute already covers it.Note:
notes.label.filter.placeholderandnotes.label.resetFilteralready existed in this branch'snotesPortlet_en.properties(added via an earlier backport, just at a different position in the file), so that hunk was a no-op here — resolved by keeping the existing entries rather than duplicating them.