fix: Reindex inserted note links reliably on notebook import - EXO-88788 - #1738
Merged
Conversation
(#1733) Inserted note links were rendered as "Content has been deleted" after import, mostly for notes whose names contain special characters (accents, dots, ...). - Export: apply processInsertedNotes() in the "export all" path so links are converted to reindex markers like the per-note export. - Import: resolve links against a name -> id map of the imported notes (by id), instead of a name based lookup that is unreliable for special characters. Links to notes not included in the export stay unresolved, as there is no target to reindex them to. fix: Reindex content-link anchor note ids on import - EXO-88788 (#1736) "Insert note" links stored as anchors carry the note id in their attributes (data-object="notes:<id>" and href=".../notes/<id>"), but the import reindex only handled the legacy "content-link" element format. Those anchors kept the source ids after import and rendered as "Content has been deleted". Build a source id -> imported id map during import and remap the ids carried by content-link anchors. References to notes outside the import are left unchanged.
hakermi
enabled auto-merge (squash)
July 28, 2026 14:39
|
Jihed525
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserted note links were rendered as "Content has been deleted" after import, mostly for notes whose names contain special characters (accents, dots, ...).