Adopt #9's html.py extensions on the shared base - #18
Open
ahoblitz wants to merge 1 commit into
Open
Conversation
|
|
ahoblitz
changed the title
ahoblitz
marked this pull request as ready for review
August 8, 2026 18:00
ahoblitz
force-pushed
the
shared-base-reconciliation
branch
from
August 10, 2026 12:54
1f11801 to
063d9dd
Compare
Contributor
|
My recommendation is to merge this first so the other PRs can rebase on this. Suggested changes (see other comments in code):
|
zndr27
suggested changes
Aug 17, 2026
zndr27
reviewed
Aug 17, 2026
Collaborator
|
All of @zndr27 suggested changes look good. |
ahoblitz
force-pushed
the
shared-base-reconciliation
branch
2 times, most recently
from
August 23, 2026 19:08
71fa31f to
5480c38
Compare
ahoblitz
changed the title
ahoblitz
force-pushed
the
shared-base-reconciliation
branch
from
August 23, 2026 19:16
5480c38 to
1fce4ab
Compare
Takes the html_to_markdown changes from MedARC-AI#9 so its CPS scraper, and the other HTML scrapers behind it, do not have to reapply them after merge: - in-page anchors stay relative instead of being absolutized - drop_numeric_citations makes citation stripping opt-out - sup_symbol="<sup>" preserves superscripts html.py is byte-identical to MedARC-AI#9's head. It could not be cherry-picked: all three of MedARC-AI#9's commits also touch cps.py, and the first rewrites __init__.py and cli.py in the pre-registry shape MedARC-AI#21 replaced. The unregistered-source assertion in test_scraping_cli.py was pinned to the literal "all, nice", which goes stale as soon as a source is added. It now derives from the registry. Co-authored-by: mkrastev <matey_krastev2@hotmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ahoblitz
force-pushed
the
shared-base-reconciliation
branch
from
August 23, 2026 19:34
1fce4ab to
8b1d435
Compare
ahoblitz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per review, the scrapers are out — #8, #9 and #10 rebase onto the registry from #21 and merge themselves.
What's left is review item 3: #9's
html_to_markdown, byte-identical to its head, so the HTML scrapers behind it don't reapply it.