[SS-97] Tests and benchmarks for MySQL snapshot#37698
Merged
peterdukelarsen merged 1 commit intoJul 17, 2026
Merged
Conversation
peterdukelarsen
force-pushed
the
pl/mysql-snapshot-tests
branch
5 times, most recently
from
July 16, 2026 21:58
b2be70f to
79512bd
Compare
peterdukelarsen
marked this pull request as ready for review
July 17, 2026 15:17
Add mysql-cdc multi-worker snapshot-correctness testdrive cases and the MySqlInitialLoadMultiWorker* feature-benchmark scenarios ahead of the parallel PK-range snapshot implementation. They run and pass against the current single-worker-per-table snapshot (the testdrive cases assert data correctness regardless of partitioning; the benchmarks establish a pre-feature baseline), so the implementation PR stays focused on snapshot.rs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
peterdukelarsen
force-pushed
the
pl/mysql-snapshot-tests
branch
from
July 17, 2026 15:27
79512bd to
1d729a7
Compare
patrickwwbutler
approved these changes
Jul 17, 2026
Contributor
There was a problem hiding this comment.
LGTM, though maybe we want @def- to have a look at some of the finer details of the benchmarking. I think the parallel workload failure is unrelated, given you didn't add anything there
def-
approved these changes
Jul 17, 2026
def-
left a comment
def-
left a comment
Contributor
There was a problem hiding this comment.
These tests lgtm, thanks for adding them!
peterdukelarsen
merged commit Jul 17, 2026
ba99c4b
into
MaterializeInc:main
257 of 262 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Setting up tests and benchmarks for #37642 ahead of time where possible.
Description
Verification
The first benchmark was used to show the speedup, the second caught a regression in the original version of the PR, and the testdrive tests should help with any obvious/simple correctness issues.