storage: fix dyncfg implementation - #26189
Merged
Merged
Conversation
guswynn
added
the
release-blocker
guswynn
approved these changes
Mar 21, 2024
guswynn
left a comment
guswynn
left a comment
Contributor
There was a problem hiding this comment.
yikes
I tested before I changed this based on some code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #26186 I found that the dyncfg implementation for storage was broken and
ALTER SYSTEM SET <flag> <val>commands would not work since the dyncfg option field inStorageParameterswas mistakenly 'taken' before being propagated through downstream storage configuration update commands.This is a cherry-pick of the first commit in that PR to make the fix in for the release. The tests in that PR confirm the fix.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.